Remove Direct GT4Py Imports#114
Merged
fmalatino merged 12 commits intoNOAA-GFDL:developfrom May 22, 2025
Merged
Conversation
Collaborator
Author
Contributor
|
Hi @CharlesKrop please update this branch to contain the commits from 117 |
oelbert
requested changes
May 5, 2025
Collaborator
oelbert
left a comment
oelbert
left a comment
There was a problem hiding this comment.
Looks good for the most part, except I'd rather we used import ndsl.dsl.gt4py as gt or some other name so it's clear where the decorators and I, J, K notation are coming from
fmalatino
previously approved these changes
May 14, 2025
Merged
Collaborator
|
The PR needed has been merged go ahead and re-merge with develop again |
…s crash during tests
oelbert
reviewed
May 16, 2025
| ### GT4Py stencils | ||
|
|
||
| We interface to `gt4py.cartesian.gtscript.stencil` through ndsl.dsl.stencil, specifically the FrozenStencil, that allows us to minimize runtime overhead in calling stencils. | ||
| We interface to `ndsl.dsl.gt4py.stencil` through ndsl.dsl.stencil, specifically the FrozenStencil, that allows us to minimize runtime overhead in calling stencils. |
Collaborator
There was a problem hiding this comment.
If we're changing this line maybe we could say "we interface to gt4py.cartesian stencils" since this redundancy seems a bit awkward
7 tasks
FlorianDeconinck
previously approved these changes
May 19, 2025
Collaborator
FlorianDeconinck
left a comment
FlorianDeconinck
left a comment
There was a problem hiding this comment.
Fix CONTRIBUTING.md then we are ready for show
Collaborator
|
Speaking of contributing, @CharlesKrop, if you want, you can add your name to the list of contributors in |
fmalatino
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All references to GT4Py have been removed and replaced with imports from NDSL, bringing this repository in compliance with the changes made to NDSL here.
All future references to GT4Py tools should be references via
ndsl.dsl.gt4pyinstead ofgt4py.cartesian.gtscript.